Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable22] Fix collaborative tags styles #30022

Merged
merged 1 commit into from
Dec 2, 2021
Merged

[stable22] Fix collaborative tags styles #30022

merged 1 commit into from
Dec 2, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #30018

@Pytal @backportbot
Fix collaborative tags styles
3134370 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@backportbot-nextcloud backportbot-nextcloud bot added bug design Design, UI, UX, etc. labels Dec 1, 2021
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 22.2.4 milestone Dec 1, 2021
@MichaIng MichaIng mentioned this pull request Dec 2, 2021
Merged
@MichaIng
Copy link
Member

MichaIng commented Dec 2, 2021

jsunit currently fails on all stable22 base branch + PR checks the same way.

@MichaIng MichaIng merged commit 68c1c05 into stable22 Dec 2, 2021
@MichaIng MichaIng deleted the backport/30018/stable22 branch December 2, 2021 01:41
@Pytal
Copy link
Member

Pytal commented Dec 2, 2021 •
edited
Loading

jsunit currently fails on all stable22 base branch + PR checks the same way.

@MichaIng which change started causing these failures?

edit: it looks like the use of node-sass in autotest-js.sh causes the failure

./autotest-js.sh: line 31: ./build/bin/node-sass: No such file or directory

@Pytal Pytal mentioned this pull request Dec 2, 2021
Merged
@MichaIng
Copy link
Member

MichaIng commented Dec 2, 2021

Not sure either, just recognised the exact same errors on three stable22 PRs (here, #30038 and #30019), hence it must have been something in stable22 itself. But nothing obvious for me to identify since the last commit was a transifex update and the one before didn't have the errors 🤔. So something must have changed externally.

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2022
Merged
9 tasks
@skjnldsv skjnldsv mentioned this pull request Jan 20, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaIng MichaIng MichaIng approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@artonge artonge artonge approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 22.2.4
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaIng @Pytal @artonge @CarlSchwan